Skip to content

Conversation

JCQuintas
Copy link
Member

The filterAttributeSafeProperties function aims to extract properties that can be safely used as attribute <text fontSize> vs those who are only available as style <text style={{ lineHeight }}.

This provides easier styling with css for the safe attributes

@JCQuintas JCQuintas self-assigned this Aug 28, 2025
@JCQuintas JCQuintas added type: bug It doesn't behave as expected. scope: charts Changes related to the charts. labels Aug 28, 2025
@mui-bot
Copy link

mui-bot commented Aug 28, 2025

Deploy preview: https://deploy-preview-19373--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 🔺+1.51KB(+0.36%) 🔺+281B(+0.21%)
@mui/x-charts-pro 🔺+1.51KB(+0.28%) 🔺+409B(+0.24%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 67ad119

Copy link

codspeed-hq bot commented Aug 28, 2025

CodSpeed Performance Report

Merging #19373 will improve performances by 8.75%

Comparing JCQuintas:style-attribute (612b045) with master (63e1254)1

Summary

⚡ 1 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
ScatterChartPro with big data amount 436.6 ms 401.4 ms +8.75%

Footnotes

  1. No successful run was found on master (5bd5fcd) during the generation of this report, so 63e1254 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: charts Changes related to the charts. type: bug It doesn't behave as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants