[code-infra] Configure infra packages renovate groups #2562
Conversation
commit: |
Bundle size report
|
| @@ -24,13 +24,11 @@ | |||
| }, | |||
| { | |||
| "groupName": "MUI public packages", | |||
There was a problem hiding this comment.
This doesn't apply just to MUI public packages anymore
There was a problem hiding this comment.
I believe in the preset
{
"groupName": "MUI public packages",
"matchPackageNames": ["@mui/*"]
},creates the group, and
{
"groupName": "MUI infra packages",
"matchPackageNames": ["@mui/internal-*", "@mui/docs"],
"followTag": "canary",
"schedule": null
},filters out the infra packages into its own group
As far as I understand, a package can only belong to one group at a time.
edit: Will update the group, just to be sure
There was a problem hiding this comment.
Do we still need this group if it is coming from mui-public? 🤔
There was a problem hiding this comment.
This just configures it with "allowedVersions": "!/-dev/". not sure whether that is still relevant
There was a problem hiding this comment.
Don't we release packages as canary now? 🤔
https://www.npmjs.com/package/@mui/internal-code-infra?activeTab=versions
Wasn't this only relevant to avoid bumps when we were releasing on each push to a branch?
cc @michaldudak
There was a problem hiding this comment.
There are still some packages published from the core repo. However I would discourage using the canary publish script. I think by now all latest versions are higher than the dev versions
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -24,13 +24,11 @@ | |||
| }, | |||
| { | |||
| "groupName": "MUI public packages", | |||
There was a problem hiding this comment.
Do we still need this group if it is coming from mui-public? 🤔
| "allowedVersions": "!/-dev/" | ||
| }, | ||
| { | ||
| "matchDepTypes": ["devDependencies"], |
There was a problem hiding this comment.
My hunch is also the same - that this group is breaking the playwright bump. 🙈
There was a problem hiding this comment.
The group is created by matchDepTypes and matchPackageNames, I'm not sure it includes playwright.
edit: ah, but this one may, yes!
edit 2: opening mui/mui-public#583
Reconfigure existing groups