Fix: Don't fail on domains with no records #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aellwein
reviewed
Jan 29, 2024
provider/netcup.go
Outdated
| recs, err := p.session.InfoDnsRecords(zoneName) | ||
| if err != nil { | ||
| _ = level.Error(p.logger).Log("msg", "unable to get DNS records for domain", "zone", zoneName, "error", err) | ||
| if p.session.LastResponse.Status == string(nc.StatusError) && p.session.LastResponse.StatusCode == 5029 { |
There was a problem hiding this comment.
LGTM, i would maybe check additionally for if p.session.LastResponse != nil, just not to assume that my client implementation would always be correct to set this 🤣
mrueg
force-pushed
the
fix-empty-records
branch
from
8be5f81 to
af3fe8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @webwurst @aellwein
This hopefully fixes the issue, I still need to test it tomorrow with an empty domain (and might change it to logLevel debug depending on how noisy it is)
Fixes: #5