Skip to content

Conversation

Rikahei
Copy link
Contributor

@Rikahei Rikahei commented Aug 27, 2025

Description

Looks like the href parameter of language is missing in manual/#xx/lights: OrbitControls

Error occurred after clicked OrbitControls in manual page.

Target URL: https://threejs.org/manual/#en/lights

@Rikahei Rikahei changed the title Docs: Fix missed href parameters Docs: Fix missed href parameters for manual/#xx/lights Aug 27, 2025
@Mugen87 Mugen87 changed the title Docs: Fix missed href parameters for manual/#xx/lights Manual: Fix missed href parameters for manual/#xx/lights Aug 27, 2025
@Mugen87 Mugen87 added this to the r180 milestone Aug 27, 2025
@Mugen87 Mugen87 merged commit 0cd49e3 into mrdoob:dev Aug 27, 2025
8 checks passed
@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 27, 2025

BTW: I have noticed that the <a> tags make no use of target="_blank". That's why the links open inside the iFrame which isn't ideal. If you are interested, it would be great to fix that as well with an additional PR.

@Rikahei
Copy link
Contributor Author

Rikahei commented Aug 28, 2025

BTW: I have noticed that the <a> tags make no use of target="_blank". That's why the links open inside the iFrame which isn't ideal. If you are interested, it would be great to fix that as well with an additional PR.

@Mugen87
Do you mean the double opened content text?
if so, it bother me too. I will see what I can do to fix this.

Screenshot 2025-08-28 at 10 47 40

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 28, 2025

Yes, adding target="_blank" will make sure the pages open in a separate tab.

@Rikahei
Copy link
Contributor Author

Rikahei commented Aug 28, 2025

Yes, adding target="_blank" will make sure the pages open in a separate tab.

@Mugen87

Hi, I think all the manual's href has same issue. Fix in HTML one by one maybe not ideal.

How about add a default target attribute "_blank" for all non-preset attributes by a function.

What do you think?

#31774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants