ProjectorLightNode: Remove obsolete `toVar()`. #31474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Mugen87 merged 1 commit into mrdoob:dev from Mugen87:dev3

Jul 22, 2025

Collaborator

Mugen87 commented Jul 22, 2025

Related issue: #31459

Description

Thanks to #31459, the code in ProjectorLightNode.getSpotAttenuation() can be simplified.


          ProjectorLightNode: Remove obsolete toVar().

3af850d

Mugen87 added this to the r179 milestone

github-actions bot commented Jul 22, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	337.92 78.83	337.92 78.83	+0 B +0 B
WebGPU	560.22 155.11	560.22 155.1	-8 B -5 B
WebGPU Nodes	559.15 154.89	559.14 154.89	-8 B -4 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	469.19 113.49	469.19 113.49	+0 B +0 B
WebGPU	635.39 172.03	635.38 172.03	-8 B -1 B
WebGPU Nodes	590.04 161.27	590.03 161.27	-8 B -2 B

Mugen87 merged commit 868515f into mrdoob:dev

8 of 9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet