Skip to content

Conversation

s-rigaud
Copy link
Contributor

Fix some TS errors in the project

Copy link

github-actions bot commented Jul 19, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.04
78.86
338.04
78.86
+0 B
+0 B
WebGPU 559.11
154.78
559.11
154.78
+0 B
+0 B
WebGPU Nodes 558.03
154.56
558.03
154.56
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.29
113.56
469.29
113.56
+0 B
+0 B
WebGPU 634.4
171.81
634.4
171.81
+0 B
+0 B
WebGPU Nodes 589.53
161.13
589.53
161.13
+0 B
+0 B

* @return {Vector2} The drawing buffer size.
*/
getDrawingBufferSize() {
getDrawingBufferSize( /* target */ ) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line isn't correct. Backend.getDrawingBufferSize() has indeed no target.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target argument can be removed from below lines:

const { width, height } = this.getDrawingBufferSize( _drawingBufferSize );

const { width, height } = this.getDrawingBufferSize( _drawingBufferSize );

@Mugen87 Mugen87 merged commit 7ff0f18 into mrdoob:dev Jul 21, 2025
7 of 8 checks passed
@Mugen87 Mugen87 added this to the r179 milestone Jul 21, 2025
@s-rigaud s-rigaud deleted the fix-types branch August 24, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants