RoundedBoxGeometry: add type, parameters and toJSON #31340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RoundedBoxGeometry
'sparameters
object by default holdsBoxGeometry
's parameters (since it extendsBoxGeometry
).As a result:
segments
andradius
values passed in the constructor are lost after geometry is created.toJSON
method returns data relevant to creating aBoxGeometry
.This PR
parameters
key hold the actual values passed to create the geometry.geometry.type
toRoundedBoxGeometry
instead ofBoxGeometry
.toJSON
method and make it return the correct data.fromJSON
method now returns the correctRoundedBoxGeometry
instance instead of aBoxGeometry
.The
geometry.parameters
before and after fornew RoundedBoxGeometry(1, 2, 3, 4, 0.125)
:Output from
.toJSON()
:Output from
RoundedBoxGeometry.fromJSON(data)
Before and after: