KTX2Loader: Support ETC2, BCn, and ASTC 4x4 sRGB #31155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Had to remove the KTX2 example from the E2E list, unfortunately. The failure is caused by different font rendering, nothing to do with the WebGL canvas: macOS Linux |
|
Meh, some day we'll figure out the E2E system... |
Mugen87
approved these changes
May 27, 2025
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* KTX2Loader: Support .setPath() * KTX2Loader: Add compressed formats * Examples: Organize KTX2 example in sections * update examples, fix missing formats * clean up * clean up * clean up * remove unused textures * remove ktx2 example from E2E :(
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* KTX2Loader: Support .setPath() * KTX2Loader: Add compressed formats * Examples: Organize KTX2 example in sections * update examples, fix missing formats * clean up * clean up * clean up * remove unused textures * remove ktx2 example from E2E :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates KTX2Loader to support more GPU compression formats, and replaces the existing KTX2 example.
The new example should be better at explaining and testing the available KTX2 compression types. I've updated all previous
.ktx2sample files. The new textures are much smaller, each only 1-8kb, see https://github.com/donmccurdy/KTX2-Samples. Samples cover common formats, with "srgb" and "srgb-linear" color spaces. If the general approach looks OK, future PRs can extend the example to include array textures, cube textures, 3D textures, and perhaps other color spaces.Preview