ImageBitmapLoader: Make error handling more robust. #31088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
ycw
reviewed
May 12, 2025
|
Would you mind update the class's jsdoc to clarify the limitation of current implementation: - /* Also note that unlike {@link FileLoader}, this loader does not avoid multiple concurrent requests to the same URL.
+ /* Also note that unlike {@link FileLoader}, this loader avoids multiple concurrent requests to the same URL only if `Cache` is enabled.FWIW, FileLoader can achieve this without global |
|
Thanks. |
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* ImageBitmapLoader: Make error handling more robust. * ImageBitmapLoader: Simplify code. * ImageBitmapLoader: Improve comment. * ImageBitmapLoader: Improve docs.
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
* ImageBitmapLoader: Make error handling more robust. * ImageBitmapLoader: Simplify code. * ImageBitmapLoader: Improve comment. * ImageBitmapLoader: Improve docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #31083.
Description
The PR fixes a bug in
ImageBitmapLoaderthat can appear when more than one image loader try to load an erroneous URL with enabled caching. In that case, not allonError()callback were executed.The idea of the PR is to keep track of the error object so it can be used to detect an error situation for duplicated requests.