Editor: Fix selection box update when reparenting objects in hierarchy #30904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When moving objects in the hierarchy panel to become children of other objects, the selection box in the viewport didn't update to reflect the object's new world transformation, causing a visual discrepancy between the actual object position and its selection highlight.
threejs-editor-selectionBoxIssue.mp4
Solution
Added appropriate signal dispatch in the MoveObjectCommand's execute() and undo() methods to ensure the selection box properly updates when objects are reparented. This ensures the selection box correctly reflects the object's new world transformation after hierarchy changes.
The fix properly leverages the existing signal system to update the selection box geometry without requiring changes to the Viewport.js implementation, which already handles the selectionBox updates when receiving objectChanged signals.
Testing
Verified that when dragging objects in the hierarchy panel to become children of other objects, the selection box now properly updates to match the object's new position in the scene.
threejs-editor-fixed.mp4