TSL: Simplify expression output #30691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sunag merged 1 commit into mrdoob:dev from RenaudRohlinger:utsubo/fix/simplify-expression

Mar 11, 2025

Collaborator

RenaudRohlinger commented Mar 9, 2025

Description
We don't need the extra () in ExpressionNode.

With this PR: array[ u32( ( i ) ) ] -> array[ u32( i ) ].

Before:

After:

This contribution is funded by Utsubo


          TSL: Simplify expression output

7b1f61b

github-actions bot commented Mar 9, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	336.02 78.26	336.02 78.26	+0 B +0 B
WebGPU	523.98 145.48	523.97 145.48	-9 B -2 B
WebGPU Nodes	523.45 145.37	523.44 145.37	-9 B -1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.06 112.14	465.06 112.14	+0 B +0 B
WebGPU	594.38 161.07	594.37 161.07	-9 B -4 B
WebGPU Nodes	549.51 150.51	549.5 150.51	-9 B -2 B

RenaudRohlinger added this to the r175 milestone

sunag merged commit 382d67a into mrdoob:dev

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet