JSDoc: More docs and fixes. #30541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Mugen87 merged 1 commit into mrdoob:dev from Mugen87:dev3

Feb 17, 2025

Collaborator

Mugen87 commented Feb 17, 2025

Related issue: #30534

Description

Adds JSDoc for EventDispatcher and Object3D and fixes two found bugs in the template.


          JSDoc: More docs and fixes.

github-actions bot commented Feb 17, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	336.36 78.33	336.36 78.33	+0 B +0 B
WebGPU	518.85 144	518.85 144	+0 B +0 B
WebGPU Nodes	518.32 143.88	518.32 143.88	+0 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.35 112.17	465.35 112.17	+0 B +0 B
WebGPU	590.68 159.95	590.68 159.95	+0 B +0 B
WebGPU Nodes	545.99 149.43	545.99 149.43	+0 B +0 B

Mugen87 merged commit 11c1261 into mrdoob:dev

12 checks passed

Mugen87 added this to the r174 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet