Skip to content

Conversation

s-rigaud
Copy link
Contributor

Description

Add eslint rule to remove old object.function.apply( object, values ) in favor of object.function( ...values )

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.42
78.33
336.36
78.33
-62 B
-4 B
WebGPU 518.01
143.92
518.01
143.92
+0 B
+0 B
WebGPU Nodes 517.48
143.81
517.48
143.81
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.41
112.17
465.35
112.17
-62 B
-5 B
WebGPU 589.89
160.02
589.89
160.02
+0 B
+0 B
WebGPU Nodes 545.26
149.56
545.26
149.56
+0 B
+0 B

@Mugen87 Mugen87 added this to the r174 milestone Feb 15, 2025
@Mugen87 Mugen87 merged commit d264b7c into mrdoob:dev Feb 15, 2025
12 checks passed
@s-rigaud s-rigaud deleted the eslint-implement-prefer-spread branch February 17, 2025 13:40
@WORMSS
Copy link
Contributor

WORMSS commented Feb 27, 2025

Beautiful... 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants