WebGLBackend: Fix clear().
#30485
Merged
WebGLBackend: Fix clear().
#30485
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
force-pushed
the
dev3
branch
3 times, most recently
from
7c34f66 to
05fc928
Compare
Mugen87
changed the title
clear().clear().
Mugen87
commented
Feb 9, 2025
| @@ -1917,7 +1917,17 @@ class Renderer { | |||
| renderContext.depth = renderTarget.depthBuffer; | |||
| renderContext.stencil = renderTarget.stencilBuffer; | |||
| // #30329 | |||
| renderContext.clearColorValue = this._clearColor; | |||
| renderContext.clearColorValue = this.backend.getClearColor(); | |||
There was a problem hiding this comment.
Color values assigned to RenderContext.clearColorValue must be in working color space and must honor premultiply alpha. Both were missing so far leading to incorrect clear colors when using renderer.setClearColor().
This was referenced Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30329
Description
The PR makes sure
WebGLBackend.clear()honors the user-defined clear depth and stencil values.It also makes sure clear colors set via
setClearColor()are in the working color space and honor premultiplied alpha.