StructTypeNode: Fix inclusion when added to the layout. #30439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sunag merged 1 commit into mrdoob:dev from sunag:dev-fix-struct-include

Feb 1, 2025

Collaborator

sunag commented Feb 1, 2025

Fixes: #30434

Description

Fix inclusion when added to the layout.


          StructTypeNode: Fix inclusion when added to the layout.

15ff09b

github-actions bot commented Feb 1, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	336.27 78.29	336.27 78.29	+0 B +0 B
WebGPU	517.08 143.61	517.16 143.63	+81 B +19 B
WebGPU Nodes	516.54 143.5	516.63 143.52	+81 B +20 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.25 112.13	465.25 112.13	+0 B +0 B
WebGPU	589.09 159.7	589.14 159.74	+53 B +43 B
WebGPU Nodes	544.45 149.25	544.5 149.3	+53 B +46 B

sunag marked this pull request as ready for review

February 1, 2025 02:07

sunag added this to the r174 milestone

sunag merged commit d6446ef into mrdoob:dev

12 checks passed

sunag deleted the dev-fix-struct-include branch

February 1, 2025 02:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet