XRManager: Clean up. #30349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Mugen87 merged 1 commit into mrdoob:dev from Mugen87:dev2

Jan 17, 2025

Collaborator

Mugen87 commented Jan 17, 2025 •

edited

Loading

Related issue: #30346

Description

Minor JSDoc related clean up.


          XRManager: Clean up.

a660393

Mugen87 added this to the r173 milestone

Mugen87 merged commit 3434275 into mrdoob:dev

5 of 6 checks passed

github-actions bot commented Jan 17, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	336.25 78.28	336.25 78.28	+0 B +0 B
WebGPU	503.18 139.76	503.18 139.76	+0 B +0 B
WebGPU Nodes	502.65 139.65	502.65 139.65	+0 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.25 112.13	465.25 112.13	+0 B +0 B
WebGPU	576.96 156.41	576.96 156.41	+0 B +0 B
WebGPU Nodes	532.35 145.96	532.35 145.96	+0 B +0 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet