Skip to content

WebGLBackend: Fix ArrayCamera pixel ratio #30338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2025
Merged

WebGLBackend: Fix ArrayCamera pixel ratio #30338

merged 1 commit into from
Jan 16, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jan 16, 2025

Related issue: #30337 (comment)

Description

Fix ArrayCamera pixel ratio on WebGLBackend.

@sunag sunag added this to the r173 milestone Jan 16, 2025
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.53
79.09		 339.53
79.09		 +0 B
+0 B
WebGPU 493.58
137.21		 493.59
137.22		 +7 B
+15 B
WebGPU Nodes 493.05
137.1		 493.05
137.12		 +7 B
+16 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.41
112.16		 465.41
112.16		 +0 B
+0 B
WebGPU 564.11
152.87		 564.12
152.88		 +7 B
+13 B
WebGPU Nodes 519.5
142.44		 519.5
142.46		 +7 B
+13 B

Mugen87
Mugen87 reviewed Jan 16, 2025
View reviewed changes
@sunag sunag marked this pull request as ready for review January 16, 2025 22:06
@sunag sunag merged commit 0195417 into mrdoob:dev Jan 16, 2025
12 checks passed
@sunag sunag deleted the dev-fix-pixelratio branch January 16, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r173
Development

Successfully merging this pull request may close these issues.
2 participants
@sunag @Mugen87