Skip to content

Rename timeStampQuerySet to timestampQuerySet #30289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Rename timeStampQuerySet to timestampQuerySet #30289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/renderers/webgpu/WebGPUBackend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,21 +1468,21 @@ class WebGPUBackend extends Backend {

const renderContextData = this.get( renderContext );

if ( ! renderContextData.timeStampQuerySet ) {
if ( ! renderContextData.timestampQuerySet ) {


const type = renderContext.isComputeNode ? 'compute' : 'render';
const timeStampQuerySet = this.device.createQuerySet( { type: 'timestamp', count: 2, label: `timestamp_${type}_${renderContext.id}` } );
const timestampQuerySet = this.device.createQuerySet( { type: 'timestamp', count: 2, label: `timestamp_${type}_${renderContext.id}` } );

const timestampWrites = {
querySet: timeStampQuerySet,
querySet: timestampQuerySet,
beginningOfPassWriteIndex: 0, // Write timestamp in index 0 when pass begins.
endOfPassWriteIndex: 1, // Write timestamp in index 1 when pass ends.
};

Object.assign( descriptor, { timestampWrites } );

renderContextData.timeStampQuerySet = timeStampQuerySet;
renderContextData.timestampQuerySet = timestampQuerySet;

}

Expand Down Expand Up @@ -1523,7 +1523,7 @@ class WebGPUBackend extends Backend {
const { resolveBuffer, resultBuffer } = renderContextData.currentTimestampQueryBuffers;


encoder.resolveQuerySet( renderContextData.timeStampQuerySet, 0, 2, resolveBuffer, 0 );
encoder.resolveQuerySet( renderContextData.timestampQuerySet, 0, 2, resolveBuffer, 0 );

if ( resultBuffer.mapState === 'unmapped' ) {

Expand Down
Loading