OrbitControls: Add keyRotateSpeed.
#29988
Conversation
This allows for setting a different speed of rotation when using the keyboard vs when using a mouse. Similar in approach to the existing keyPanSpeed.
ghost
changed the title
| @@ -92,6 +92,7 @@ class OrbitControls extends Controls { | |||
| // Set to false to disable rotating | |||
| this.enableRotate = true; | |||
| this.rotateSpeed = 1.0; | |||
| this.keyRotateSpeed = 10.0; | |||
There was a problem hiding this comment.
Would you mind not changing the default value so we don't change the behavior?
There was a problem hiding this comment.
Happy to change this default to 1 as it's now configurable. But .. The default of 1 is fairly slow when moving with the keyboard. Having a slightly faster speed, would be similar to keyPanSpeed which is also higher when using the keyboard (7 vs 1).
The following recordings is me just holding shift+ down, so no repeated presses:
keyRotateSpeed = 1
key-rotate-1.mov
keyRotateSpeed = 10
key-rotate-10.mov
Let me know what you think, happy to go either way on this
There was a problem hiding this comment.
Um, at least on my macMini the the rotate speed feels a bit too high.
TBH, I feel more safe if we don't touch the default value. Is that okay for you?
There was a problem hiding this comment.
No worries at all, I pushed a commit which sets it to 1
Mugen87
changed the title
keyRotateSpeed.
* feat: Add keyRotateSpeed to OrbitControls This allows for setting a different speed of rotation when using the keyboard vs when using a mouse. Similar in approach to the existing keyPanSpeed. * fix: reduce keyRotateSpeed down to 1
Description
This allows for setting a different speed of rotation when using the keyboard vs when using a mouse. Similar in approach to the existing keyPanSpeed.