Eslint: Improve config #29981
Merged
Eslint: Improve config #29981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Nov 27, 2024
Mugen87
reviewed
Nov 27, 2024
Mugen87
reviewed
Nov 27, 2024
Mugen87
reviewed
Nov 27, 2024
|
Do you mind resolving the merge conflicts? |
s-rigaud
force-pushed
the
improve-eslint-config
branch
from
93b3b94 to
7269412
Compare
cmhhelgeson
pushed a commit
to cmhhelgeson/three.js
that referenced
this pull request
Dec 5, 2024
* Eslint: Improve config * Only keep import merging --------- Co-authored-by: Samuel Rigaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I figured out from reading PRs or making one that some eslint rules might be added to the project to improve code quality.
As the core developers will be mainly impacted by the rule changes, you are in a better spot to judge what rules should be added or not. This PR is just a small suggestion.
I updated the code with new rules to get a preview of the changes (there is no error left).