Tests: Use absolute delta value when comparing against tolerance #29946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the equals functions in the unit tests (e.g.
matrixEquals4
) incorrectly compared signed delta values to the tolerance threshold, instead of absolute values. As a result differences whereb > a
would never "exceed" the tolerance and always pass.Additionally the
bufferAttributeEquals
failed to actually compare the contents of the attributes. After resolving this issue, it became clear that thecomputeVertexNormals (indexed)
test was broken. I tried to find out what the original intention of the test was but it seems it was introduced in a broken state in #12354. As such, I've taken the liberty to tweak it so that:computeVertexNormals
can actually compute all values)This contribution is funded by Fern Solutions