BatchedMesh: Refactor error handling. #29591

Makio64 · 2024-10-08T14:34:13Z

Description

Replace "silent error handling" by throwing clear error message to help the devs to find errors early when using BatchedMesh.

github-actions · 2024-10-08T14:37:23Z

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	692.35 171.47	693.54 171.54	+1.19 kB +73 B
WebGPU	822.05 221.87	823.24 222.02	+1.19 kB +147 B
WebGPU Nodes	821.34 221.72	822.52 221.87	+1.19 kB +147 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	464.89 112.3	464.89 112.3	+0 B +0 B
WebGPU	542.63 146.81	542.63 146.81	+0 B +0 B
WebGPU Nodes	498.57 136.54	498.57 136.54	+0 B +0 B

* GTAONode: Fix AO with WebGL backend. * E2E: Update screenshot. * DenoiseNode: Use `getViewPosition()` from core. * DenoiseNode: Clean up.

* improve outline example * rev

…rt maps definitions location.

Co-authored-by: aardgoose <[email protected]>

src/objects/BatchedMesh.js

* Addons: Add `SSRNode`. * E2E: Update screenshot. * SSRNode: Clean up. * SSRNode: Honor material in `dispose()`.

…rdoob#29598) * Improve names, replaced some `save` to `reset` * Update SSRNode.js

Makio64 · 2024-10-09T19:09:12Z

I was wondering if the error message shouldn't be factorize in function ?
validateInstanceId(instanceId, drawRanges)
validateGeometryId(geometryId, drawRanges)

Like :

function validateGeometryId(geometryId, drawRanges) {
  if (geometryId >= drawRanges.length || drawRanges[geometryId].active === false) {
    throw new Error(`BatchedMesh: Invalid geometryId ${geometryId}. Geometry is either out of range or has been deleted.`);
  }
}

* PostProcessingUtils: Add `getScreenPosition()`. * renamed types: `matrix4` -> `mat4` ---------

) * WebGPURenderer: Fix geometry attribute not updated regardless of version * BufferAttributes don't have uuid * small cleanup * more cleanup * improve geometry comparison performance * cleanup previous implementation * attributes have no uuid

gkjohnson · 2024-10-09T23:21:43Z

I was wondering if the error message shouldn't be factorize in function ?
validateInstanceId(instanceId, drawRanges)
validateGeometryId(geometryId, drawRanges)

I think this is okay to do - it should simplify some of the functions

…mrdoob#29606) * added hashBlur * improve `webgpu_backdrop_area` example * loop: fix generate const in `start` and `end` * Update webgpu_backdrop_area.jpg

* add min/max constraints to TransformControls * update TransformControls documentation

* Eslint: Add `no-irregular-whitespace` rule * clean up

* `hashBlur` - added default `uv` * improve light intensity

…ob#29594) * Introducing an indirectStorageBuffer for drawIndirect * Update NodeStorageBuffer.js fixed lint issue * Update StorageBufferNode.js fixed lint issue * Update IndirectStorageBufferAttribute.js fixed lint issue * Update StorageBufferNode.js fixed lint issues * Update StorageBufferNode.js fixed lint issues * Update StorageBufferNode.js fixed lint issues * Update StorageBufferNode.js fixed lint issue * PR update * Update StorageBuffer.js * Update Bindings.js * Update Bindings.js * Update StorageBufferNode.js * rev * cleanup --------- Co-authored-by: Attila Schroeder <[email protected]> Co-authored-by: sunag <[email protected]>

* Addons: Remove `CinematicCamera`. * E2E: Remove screenshot.

* LDrawLoader: Add WebGPU support. * LDrawLoader: Improve error handling. * LDrawLoader: Clean up. * Update Addons.js

Mugen87 · 2024-10-28T08:52:40Z

Do you mind rebasing the PR?

* Docs:Manual lights.html typo * Docs:Manual lights.html code snippet intensity default 5

…ob#29759)

* NodeMaterial: Add support for `alphaHash`. * Clean up. * E2E: Update exception list. * Examples: Clean up. * NodeMaterial: Fix alpha hash check.

…ng usage (mrdoob#29729) * support for post-rendering use * cleanup * Update Textures.js * improve rectangle parameter values and types * cleanup

* TSL: Add function for computing BPCEMs. * E2E: Add example to exception list. * added on resize ---------

Remove outdated link.

Fix typo.

* WebGPURenderer: Handle Device Lost Event * small typo * feedbacks * fix * not need to bind

Update revision.

…rdoob#29769) * Add mipmap copy support * unbind buffers * working function implementation * Support signature deprecation * update docs * Infer the mipmap sizes of the src texture * Update WebGLRenderer.js Update deprecation comment. --------- Co-authored-by: Michael Herzog <[email protected]>

* Materials: Revert static types of builtins materials * git checkout materials too destructive * git checkout materials too destructive * adapt StandardNodeLibrary * git checkout materials too destructive

…io64/three.js into fix-batchedmesh-silent-error

Makio64 · 2024-11-02T14:05:16Z

closed in favor of : #29790

Refactor BatchedMesh class error handling

40d9cbc

Makio64 and others added 3 commits October 8, 2024 17:00

fix linting

34a19b8

GTAONode: Fix AO with WebGL backend. (mrdoob#29593)

35f4555

* GTAONode: Fix AO with WebGL backend. * E2E: Update screenshot. * DenoiseNode: Use `getViewPosition()` from core. * DenoiseNode: Clean up.

OutlineNode: Improve approach (mrdoob#29583)

1ae4fce

* improve outline example * rev

Mugen87 changed the title ~~Refactor BatchedMesh class error handling~~ BatchedMesh: Refactor error handling. Oct 8, 2024

WebGPURenderer: Introduce PostProcessingUtils (mrdoob#29595)

aedf298

mrdoob requested a review from gkjohnson October 8, 2024 23:15

mrdoob added this to the r170 milestone Oct 8, 2024

mrdoob and others added 2 commits October 9, 2024 15:44

Editor: Fixed editor not loading on Chrome 129.0.6668.100 due to impo…

e754fce

…rt maps definitions location.

remove obsolete method (mrdoob#29596)

aa9e4ce

Co-authored-by: aardgoose <[email protected]>

gkjohnson reviewed Oct 9, 2024

View reviewed changes

src/objects/BatchedMesh.js Outdated Show resolved Hide resolved

Mugen87 and others added 4 commits October 9, 2024 17:54

Addons: Add SSRNode. (mrdoob#29597)

1a6d5e6

* Addons: Add `SSRNode`. * E2E: Update screenshot. * SSRNode: Clean up. * SSRNode: Honor material in `dispose()`.

Examples: Clean up. (mrdoob#29600)

909af71

PostProcessingUtils: Improve names, replaced some save to reset (m…

1d91b42

…rdoob#29598) * Improve names, replaced some `save` to `reset` * Update SSRNode.js

better error message

981e8ee

Mugen87 and others added 5 commits October 9, 2024 16:14

PostProcessingUtils: Add getScreenPosition(). (mrdoob#29599)

e6e4398

* PostProcessingUtils: Add `getScreenPosition()`. * renamed types: `matrix4` -> `mat4` ---------

Updated builds.

c767fa1

SSRNode: Honor metalness. (mrdoob#29605)

5e3e26a

TSL: Introduce premultipliedGaussianBlur (mrdoob#29604)

4efe2d0

sunag and others added 7 commits October 10, 2024 00:42

Examples: Added hashBlur and improve webgpu_backdrop_area example (…

69e0515

…mrdoob#29606) * added hashBlur * improve `webgpu_backdrop_area` example * loop: fix generate const in `start` and `end` * Update webgpu_backdrop_area.jpg

TransformControls: Add min/max constraints. (mrdoob#29602)

279db99

* add min/max constraints to TransformControls * update TransformControls documentation

Eslint: Add no-irregular-whitespace rule (mrdoob#29608)

767acce

* Eslint: Add `no-irregular-whitespace` rule * clean up

GaussianBlurNode: Remove useless check. (mrdoob#29611)

3463260

ReflectorNode: Remove getTextureNode(). (mrdoob#29609)

06e4cf1

TSL: hashBlur - added default uv (mrdoob#29614)

65c13da

* `hashBlur` - added default `uv` * improve light intensity

Mugen87 added 2 commits October 28, 2024 09:44

Addons: Remove CinematicCamera. (mrdoob#29750)

751d9ec

* Addons: Remove `CinematicCamera`. * E2E: Remove screenshot.

LDrawLoader: Add WebGPU support. (mrdoob#29752)

d067dfd

* LDrawLoader: Add WebGPU support. * LDrawLoader: Improve error handling. * LDrawLoader: Clean up. * Update Addons.js

Nokic233 and others added 15 commits October 29, 2024 09:46

Docs:Manual lights.html typo (mrdoob#29756)

d59de8e

* Docs:Manual lights.html typo * Docs:Manual lights.html code snippet intensity default 5

Add Vector4.divide, to match Vector3 and Vector2 function set (mrdo…

bbfdeac

…ob#29759)

NodeMaterial: Add support for alphaHash. (mrdoob#29757)

ff6450a

* NodeMaterial: Add support for `alphaHash`. * Clean up. * E2E: Update exception list. * Examples: Clean up. * NodeMaterial: Fix alpha hash check.

Updated builds.

b7ae580

WebGPURenderer: Support Scene.backgroundRotation. (mrdoob#29762)

184cc6b

WebGPURenderer: copyFramebufferToTexture - support for post-renderi…

09c38ab

…ng usage (mrdoob#29729) * support for post-rendering use * cleanup * Update Textures.js * improve rectangle parameter values and types * cleanup

RectAreaLightNode: Fix update(). (mrdoob#29771)

83c3f72

TSL: Add function for BPCEM. (mrdoob#29773)

732bc2a

* TSL: Add function for computing BPCEMs. * E2E: Add example to exception list. * added on resize ---------

Examples: Remove raymarching GLSL demo. (mrdoob#29774)

e5f2707

Update SECURITY.md

10b2770

Remove outdated link.

Update SECURITY.md

f19ca73

Fix typo.

WebGPURenderer: Handle Device Lost Event (mrdoob#29767)

ab048e6

* WebGPURenderer: Handle Device Lost Event * small typo * feedbacks * fix * not need to bind

Updated package-lock.json

bfa78c7

Updated builds.

bf00bb0

r170

beab9e8

mrdoob modified the milestones: r170, r171 Oct 31, 2024

Mugen87 and others added 8 commits October 31, 2024 11:14

Dev: Upgrade jimp to latest version. (mrdoob#29780)

d0f64d6

Update constants.js

54c3413

Update revision.

Materials: Revert static types of builtins materials (mrdoob#29789)

c3a6e70

* Materials: Revert static types of builtins materials * git checkout materials too destructive * git checkout materials too destructive * adapt StandardNodeLibrary * git checkout materials too destructive

Refactor BatchedMesh class error handling

0dbc396

better error message

5d901a3

Merge branch 'fix-batchedmesh-silent-error' of https://github.com/Mak…

cb2cc29

…io64/three.js into fix-batchedmesh-silent-error

clean old

639ab20

Makio64 closed this Nov 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

BatchedMesh: Refactor error handling. #29591

BatchedMesh: Refactor error handling. #29591

Uh oh!

Makio64 commented Oct 8, 2024 •

edited by Mugen87

Loading

Uh oh!

github-actions bot commented Oct 8, 2024 •

edited

Loading

Uh oh!

Uh oh!

Makio64 commented Oct 9, 2024

Uh oh!

gkjohnson commented Oct 9, 2024

Uh oh!

Mugen87 commented Oct 28, 2024

Uh oh!

Makio64 commented Nov 2, 2024

Uh oh!

Uh oh!

Uh oh!

BatchedMesh: Refactor error handling. #29591

BatchedMesh: Refactor error handling. #29591

Uh oh!

Conversation

Makio64 commented Oct 8, 2024 • edited by Mugen87 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle size

🌳 Bundle size after tree-shaking

Uh oh!

Uh oh!

Makio64 commented Oct 9, 2024

Uh oh!

gkjohnson commented Oct 9, 2024

Uh oh!

Mugen87 commented Oct 28, 2024

Uh oh!

Makio64 commented Nov 2, 2024

Uh oh!

Uh oh!

Makio64 commented Oct 8, 2024 •

edited by Mugen87

Loading

github-actions bot commented Oct 8, 2024 •

edited

Loading