Skip to content

WebGLBackend: Fix type conversion in transform feedback #29554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2024
Merged

WebGLBackend: Fix type conversion in transform feedback #29554

merged 1 commit into from
Oct 5, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 5, 2024

Related issue: #29551

Description

The varying declaration was being formatted instead of the source value causing errors in some cases when using WebGLBackend.

@sunag sunag added this to the r170 milestone Oct 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 688.13
170.5		 688.13
170.5		 +0 B
+0 B
WebGPU 808.1
217.67		 808.31
217.72		 +211 B
+53 B
WebGPU Nodes 807.61
217.53		 807.82
217.58		 +211 B
+54 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.85
111.78		 462.85
111.78		 +0 B
+0 B
WebGPU 536.53
144.8		 536.53
144.8		 +0 B
+0 B
WebGPU Nodes 492.61
134.53		 492.61
134.53		 +0 B
+0 B

@sunag sunag marked this pull request as ready for review October 5, 2024 03:08
@sunag sunag merged commit b249dc8 into mrdoob:dev Oct 5, 2024
12 checks passed
@sunag sunag deleted the dev-rev-storage branch October 5, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r170
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag