WebGPURenderer: GaussianBlurNode reduce overhead #27447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why but the E2E tests now complain a diff in https://rawcdn.githack.com/aardgoose/three.js/gb/examples/webgpu_backdrop_water.html |
|
It seems #27451 has the same issue. Maybe we exclude |
Agree! This way we can create a separate PR and study this problem more calmly. |
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
* use two quadmeshes * add tip --------- Co-authored-by: aardgoose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of a single QuadMesh for both gaussian blur passes results in a single RenderObject with a SampledTexture binding that alternates between source textures and triggers creation of new BindGroups and BindGroupLayouts every frame.
Using two QuadMesh objects prevents this behaviour.