SpriteNodeMaterial scaleNode accept vec2

[Makio64]

Description

three.js/src/materials/nodes/SpriteNodeMaterial.js

Line 124 in 9a9cc2a

scale = scale.mul( float( scaleNode ) );

In SpriteNodeMaterial the scaleNode is convert to float before mutliply the scale (vec2).

It works in most case but in certain setup with orthographic & renderTarget the user might want to correct aspect ratio using a different x / y in scaleNode.

If it's ok to you I can do a PR to support this use case.

Reproduction steps

X

Code

three.js/src/materials/nodes/SpriteNodeMaterial.js

Line 124 in 9a9cc2a

scale = scale.mul( float( scaleNode ) );

to

scale = scale.mul( vec2( scaleNode ) );

Live example

X

Screenshots

X

Version

r173

Device

No response

Browser

No response

OS

No response

[Mugen87]

scale = scale.mul( vec2( scaleNode ) );

I think you can use just:

scale = scale.mul( scaleNode );

since scaleNode is supposed to be of type Node<vec2> if set.

I think we can consider this issue as a bug though.

[Makio64]

I agree but maybe there is a reason for forcing the cast to float @sunag ?

[sunag]

I agree too, I'm fixing it here.