DRIVERS-3279 clarify expected server errors in CSE prose test 4 #1832
Conversation
|
|
||
| Expect this to fail since encryption results in a document exceeding the `maxBsonObjectSize` limit. | ||
| Expect this to fail indicating the document exceeded the `maxBsonObjectSize` limit. If the write is sent to the | ||
| server, expect a server error with code 2 or 10334. |
There was a problem hiding this comment.
Do we want to explicitly require drivers check the error code here? Or only if they do check the error code, to expect these codes?
There was a problem hiding this comment.
The latter. I expect MongoCollection.bulkWrite does not prohibit client-side size checks after auto-encryption. This is only intended to check the server error code if the write is sent to the server.
There was a problem hiding this comment.
Does sending the write to the server then imply that the driver also checks the error code?
There was a problem hiding this comment.
Yes, I expect if the driver sends the write to the server (i.e. does not fail earlier with a driver-side check) that a driver should check the expected error code to ensure they get the expected error. Updated text to clarify.
3 participants
Summary
Document expected server error codes in prose test for CSFLE/QE bulkWrite prose test expecting a "too-large document" error.
Motivation
SERVER-104405 recently changed the expected error code. This broke some drivers testing of BSON Size Limits and Batch Splitting. Document the expected server errors in the specification.
Checking server error codes is not made into a requirement.
MongoCollection.bulkWritedoes not prohibit client-side checks after auto-encryption. The expected error might be a driver-side or server-side error.Please complete the following before merging:
[ ] Update changelog.clusters).