Skip to content

Conversation

@jmikola
Copy link
Member

@jmikola jmikola commented Sep 13, 2021

No description provided.

@jmikola jmikola requested a review from durran September 13, 2021 20:49
@jmikola jmikola requested a review from a team as a code owner September 13, 2021 20:49
@jmikola jmikola requested review from a team and JamesKovacs and removed request for a team, JamesKovacs and durran September 13, 2021 20:49
Copy link
Contributor

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 83 requires updating as well.

@jmikola jmikola requested a review from JamesKovacs September 13, 2021 22:37
Copy link
Contributor

@JamesKovacs JamesKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmikola jmikola merged commit 344eed9 into master Sep 15, 2021
@jmikola jmikola deleted the jmikola-patch-2 branch September 15, 2021 13:13
p-mongo pushed a commit to p-mongo/specifications that referenced this pull request Oct 25, 2021
* upstream/master: (47 commits)
  DRIVERS-1959: Expect either valid:false or warning:true, but not both (mongodb#1083)
  DRIVERS-1958: Do not expect readConcern for pre-4.2 servers (mongodb#1081)
  DRIVERS-1918 Update rules for $readPreference passing to include OP_MSG (mongodb#1076)
  DRIVERS-1956: Skip tests utilizing $out on serverless (mongodb#1080)
  DRIVERS-1519: srvMaxHosts option for limiting SRV seeding (mongodb#1069)
  Revert "Skip "listIndexes pins the cursor to a connection" on serverl… (mongodb#1079)
  Fix formatting for load-balanced topology
  Skip "listIndexes pins the cursor to a connection" on serverless (mongodb#1077)
  DRIVERS-823: Support $out and $merge on secondaries (mongodb#1062)
  DRIVERS-1141 Add missing new lines on serverConnectionId spec tests (mongodb#1074)
  DRIVERS-1631 Clarify minPoolSize requirement (mongodb#1072)
  DRIVERS-521 Use test22 for custom service name endpoint (mongodb#1073)
  DRIVERS-1929 Add missing "hello" to load balanacer spec test (mongodb#1071)
  DRIVERS-1912: Fix change log and last modified date (mongodb#1070)
  DRIVERS-521 Allow custom SRV service names with srvServiceName URI option (mongodb#1067)
  Fix link to load balancer spec (mongodb#1068)
  DRIVERS-1912 Clarify maxWireVersion check for maxStalenessSeconds (mongodb#1064)
  DRIVERS-1621: Clarify error expectation rules for parseErrors (mongodb#1066)
  Add link to ServerType in SDAM spec test description (mongodb#683)
  DRIVERS-1914 Max staleness test updates
  ...
kevinAlbs pushed a commit to kevinAlbs/specifications that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants