-
Notifications
You must be signed in to change notification settings - Fork 23
CLOUDP: 327089, CLOUDP: 317939 add status field #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+85
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
2536abe to
ae52bb4
Compare
vinilage
approved these changes
Oct 31, 2025
Collaborator
vinilage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Comment on lines
+1
to
+7
| --- | ||
| title: Surface reconciled MongoDBSearch version | ||
| kind: fix | ||
| date: 2025-10-24 | ||
| --- | ||
|
|
||
| * MongoDBSearch now records the reconciled mongot version in status and exposes it via a dedicated kubectl print column. |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lsierant
reviewed
Nov 3, 2025
lsierant
approved these changes
Nov 3, 2025
fealebenpae
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces support for tracking and updating the reconciled MongoDB Search version within the operator and its CRD status. The changes ensure that the
Status.Versionfield is set only after the StatefulSet becomes ready, and add mechanisms to pass and validate the version throughout the reconciliation workflow. Additional test coverage verifies the correct behavior before and after readiness.CRD and Status Enhancements:
Versioncolumn to theMongoDBSearchCRD for visibility inkubectl getoutput.UpdateStatusmethod to accept and set theMongoDBSearchVersionOption, allowing the controller to update the reconciled version in status.MongoDBSearchVersionOptionand related helpers instatus_options.goto encapsulate version updates for status.Controller and Reconciliation Logic:
Testing Improvements:
Status.Versionremains empty before readiness and is set correctly after the StatefulSet is ready; added a helper to simulate readiness. [1] [2] [3] [4]Proof of Work
Tests pass
Checklist
skip-changeloglabel if not needed