DOCSP-36627: Fix double backslashes #1239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Mar 4, 2024
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
The CI is failing because this is an unmaintained branch.
The doc changes SGTM.
jmikola
reviewed
Mar 4, 2024
| ---------- | ||
|
|
||
| ``$explainable`` : :phpclass:`MongoDB\\Operation\\Explainable` | ||
| ``$explainable`` : :phpclass:`MongoDB\Operation\\Explainable` |
Member
There was a problem hiding this comment.
@norareidy I think \\Explainable was missed here. Just caught it while merging v1.16 to v1.17 and grepping for \\ in the docs folder.
See: https://github.com/mongodb/mongo-php-library/pull/1243/files#r1511415758
I'm fixing this in the v1.17 PR, but you may still want to run another check for outstanding \\ occurrences in v1.16 and submit another PR for that. AFAIK, the only place \\ should still exist is within title headings.
Contributor
Author
There was a problem hiding this comment.
Sorry about that!! I found one more missed double backslash in v1.16 so I'll open a PR for that fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://jira.mongodb.org/browse/DOCSP-36627
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/php-library/DOCSP-36627-staging/