fix(shell-bson): ObjectId constructor compatibility with bson 7.x #2567
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change in the 7.x bson package that we should hide from mongosh users.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a breaking change in BSON 7.x where the ObjectId constructor no longer accepts numeric timestamps directly. The fix ensures backward compatibility by intercepting numeric inputs and routing them through createFromTime() instead.
Key Changes:
- Added special handling for numeric ObjectId constructor arguments to maintain API compatibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
addaleax
added
the
no-title-validation
gagik
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change in the 7.x bson package that we should hide from mongosh users.