Skip to content

Conversation

@addaleax
Copy link
Collaborator

Right now, the VSCode test is failing in CI because the versions of @mongodb-js/devtools-connect mismatch. We can align them the same way we aligned the driver versions.

This does not turn the task green yet, but it is a necessary step (the next one would be adjusting the VSCode source code for the removal of the argument to serviceProvider.close() from c8e2697).

Right now, the VSCode test is failing in CI because the versions
of `@mongodb-js/devtools-connect` mismatch. We can align them the
same way we aligned the driver versions.

This does not turn the task green yet, but it is a necessary step
(the next one would be adjusting the VSCode source code for the
removal of the argument to `serviceProvider.close()` from c8e2697).
@addaleax addaleax requested a review from a team as a code owner September 17, 2025 18:11
Copilot AI review requested due to automatic review settings September 17, 2025 18:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a CI test failure in the VSCode test by aligning package versions for @mongodb-js/devtools-connect and @mongodb-js/devtools-proxy-support to match the approach already used for driver version alignment.

  • Extends the existing package linking strategy to include MongoDB devtools packages
  • Removes additional conflicting packages before creating symbolic links
  • Reorganizes the linking commands into a multi-line format for better readability

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@gagik gagik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! I can try to do the VSCode adjustments

@addaleax addaleax merged commit 0e6a788 into main Sep 18, 2025
62 of 155 checks passed
@addaleax addaleax deleted the fix-test-vscode-1 branch September 18, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants