-
Notifications
You must be signed in to change notification settings - Fork 158
fix: Removes nullable from DBUser password #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fixes an issue where the atlas-create-dbusers tool was being skipped due to missing types in parameter schema by replacing separate .optional() and .nullable() chaining with the combined .nullish() method for the password field.
- Replaces chained
.optional().nullable()with.nullish()for the password field in DBUser creation schema - Resolves parameter schema validation issues that prevented the tool from being recognized by Gemini CLI
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
himanshusinghs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 🚀 @nirinchev should we pull this for 1.0.0?
|
Can we test the impact of this change with several agents - notably, we want to ensure the agent doesn't generate a password unless explicitly prompted for it. Otherwise, happy to pull it in. |
@nirinchev Tested with copilot agents GPT, grok, Claude and gemini. All exclude password or provide null value if not explicitly prompted to include password. Additionally, user provided password is used when prompted. ie, behaviour remains the same. |
If this was only in VSCode/Copilot might also be worth verifying in a different agent (i.e. Claude Desktop or Cursor) and not model just to make sure they interpret JSON schema correctly as well |
Proposed changes
Fixes #556
On Gemini CLI, tool
atlas-create-dbuserswould be skipped due tomissing types in paramter schema.This seems to be caused by setting password as both optional and nullable.
I have replaced this with nullish (both optional and nullable).
This resolves the issue.
before fix:

after fix:

Checklist