fix: incorrect number of clusters found #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a bug where the reported number of clusters was incorrect by counting table rows instead of actual cluster data. The fix ensures the cluster count matches the actual number of clusters returned from the API.
- Fixed cluster counting logic to use the combined array length instead of table rows
- Updated test to verify the count matches the parsed table data
- Refactored code to improve readability by extracting the combined clusters array
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/atlas/read/listClusters.ts | Fixed cluster counting by using allClusters.length instead of rows.length |
| tests/integration/tools/atlas/clusters.test.ts | Added verification that cluster count matches parsed table data |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nirinchev
force-pushed
the
ni/cluster-statistics
branch
from
0697a95 to
24ce438
Compare
himanshusinghs
approved these changes
Sep 16, 2025
cveticm
approved these changes
Sep 16, 2025
Collaborator
cveticm
left a comment
cveticm
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the improved test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist