-
Notifications
You must be signed in to change notification settings - Fork 111
chore: update user description #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the description text for temporary database users created by the MongoDB MCP Server to include a reference URL with more information about temporary user roles.
- Replaces the generic description with a more concise version that includes a documentation URL
- Points users to MongoDB MCP Server documentation for additional context about temporary user considerations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@@ -93,7 +93,8 @@ export class ConnectClusterTool extends AtlasToolBase { | |||
oidcAuthType: "NONE", | |||
x509Type: "NONE", | |||
deleteAfterDate: expiryDate.toISOString(), | |||
description: "This temporary user is created by the MongoDB MCP Server to connect to the cluster.", | |||
description: | |||
"Temporary user, see https://dochub.mongodb.org/core/mongodb-mcp-server-tools-considerations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of like that it was mentioning it's created by the MCP server - is it getting too long now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes :( I'm open to suggestions. dochub url is longer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe for a user wondering if it was created by the MCP Server, opening a URL that says it was created by the MCP Server is good enough. I would add, if we want to really be more clear, MCP at the beginning at that's it, something like:
MCP Temporary user, see ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it fits! actually, MDB MCP Temporary user, see..
fits
Pull Request Test Coverage Report for Build 17265225076Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Proposed changes
Checklist