Skip to content

Conversation

blva
Copy link
Collaborator

@blva blva commented Aug 26, 2025

Proposed changes

  • Adds the URL about the temporary user role

Checklist

@blva blva marked this pull request as ready for review August 26, 2025 20:10
@Copilot Copilot AI review requested due to automatic review settings August 26, 2025 20:10
@blva blva requested a review from a team as a code owner August 26, 2025 20:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the description text for temporary database users created by the MongoDB MCP Server to include a reference URL with more information about temporary user roles.

  • Replaces the generic description with a more concise version that includes a documentation URL
  • Points users to MongoDB MCP Server documentation for additional context about temporary user considerations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@blva blva requested a review from kmruiz August 27, 2025 08:34
@@ -93,7 +93,8 @@ export class ConnectClusterTool extends AtlasToolBase {
oidcAuthType: "NONE",
x509Type: "NONE",
deleteAfterDate: expiryDate.toISOString(),
description: "This temporary user is created by the MongoDB MCP Server to connect to the cluster.",
description:
"Temporary user, see https://dochub.mongodb.org/core/mongodb-mcp-server-tools-considerations",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of like that it was mentioning it's created by the MCP server - is it getting too long now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes :( I'm open to suggestions. dochub url is longer

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe for a user wondering if it was created by the MCP Server, opening a URL that says it was created by the MCP Server is good enough. I would add, if we want to really be more clear, MCP at the beginning at that's it, something like:

MCP Temporary user, see ...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fits! actually, MDB MCP Temporary user, see.. fits

@blva blva requested review from kmruiz and nirinchev August 27, 2025 10:26
@blva blva enabled auto-merge (squash) August 27, 2025 10:26
@blva blva merged commit 815b7a7 into main Aug 27, 2025
17 checks passed
@blva blva deleted the update-user-description branch August 27, 2025 11:25
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17265225076

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 81.825%

Totals Coverage Status
Change from base Build 17265186031: 0.008%
Covered Lines: 4422
Relevant Lines: 5381

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants