Skip to content

Conversation

@bennypowers
Copy link
Member

@bennypowers bennypowers commented Aug 9, 2024

What I did

  1. make the summary reporter list the suite names when flatten is true

Before:

✓ imperatively instantiates [Chromium]
✓ should upgrade [Chromium]
✓ should be hidden on init [Chromium]
✓ should not be accessible [Chromium]
✓ should be visible [Chromium]
✓ should be accessible [Chromium]
✓ should focus the component [Chromium]
✓ should be visible [Chromium]
✓ should be accessible [Chromium]
✓ should focus the component [Chromium]
✓ should be hidden [Chromium]
✓ should be visible [Chromium]
✓ should be hidden on init [Chromium]
✓ should be visible [Chromium]
✓ should have a label of "Back to top" [Chromium]
✓ should have a label of "Back to top" [Chromium]
✓ should have a label of "Return to top" [Chromium]
✓ should have a label of "Return to top" [Chromium]

After:

✓  <pf-back-to-top> imperatively instantiates [Chromium]
✓  <pf-back-to-top> simply instantiating should upgrade [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length should be hidden on init [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length should not be accessible [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length when scrolled 401px should be visible [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length when scrolled 401px should be accessible [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length when scrolled 401px pressing the tab key should focus the component [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length when the always visible property is true should be visible [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length when the always visible property is true should be accessible [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length when the always visible property is true pressing the tab key should focus the component [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length when the scroll distance is set to 1000 should be hidden [Chromium]
✓  <pf-back-to-top> when rendered in a viewport with a height smaller then content length when the scroll distance is set to 1000 when scrolled 1001px should be visible [Chromium]
✓  <pf-back-to-top> when rendered in an element with an overflowed height should be hidden on init [Chromium]
✓  <pf-back-to-top> when rendered in an element with an overflowed height when scrolled 401px should be visible [Chromium]
✓  <pf-back-to-top> when no text is provided as a link when scrolled should have a label of "Back to top" [Chromium]
✓  <pf-back-to-top> when no text is provided as a button when scrolled should have a label of "Back to top" [Chromium]
✓  <pf-back-to-top> when a label is provided as a link when scrolled should have a label of "Return to top" [Chromium]
✓  <pf-back-to-top> when a label is provided as a button when scrolled should have a label of "Return to top" [Chromium]

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 938a2e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/test-runner Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bennypowers bennypowers merged commit 6914f3b into master Aug 9, 2024
@bennypowers bennypowers deleted the summary-reporter-list-suites branch August 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants