feat: Add CORS configuration for browser-based MCP clients #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cors middleware to example servers with Mcp-Session-Id exposed - Add CORS documentation section to README - Configure minimal CORS settings (only expose required headers) This enables browser-based clients to connect to MCP servers by properly exposing the Mcp-Session-Id header required for session management. Reported-by: Jerome
jerome3o-anthropic
force-pushed
the
jerome/cors-browser-support
branch
from
6c23ed6 to
bda811a
Compare
felixweinberger
requested review from
felixweinberger
and removed request for
felixweinberger
ihrpr
requested changes
Jul 7, 2025
Contributor
ihrpr
left a comment
ihrpr
left a comment
There was a problem hiding this comment.
LGTM, just need to merge README as there is already a warning about CORS
| #### CORS Configuration for Browser-Based Clients | ||
Member
Author
There was a problem hiding this comment.
Ah up - that's just above this, I've merged them
|
|
||
| // Configure CORS to expose Mcp-Session-Id header for browser-based clients | ||
| app.use(cors({ | ||
| origin: '*', // Allow all origins - adjust as needed for production |
Contributor
There was a problem hiding this comment.
I'd probably add a very big "WARNING" here not to include "*"
Member
Author
There was a problem hiding this comment.
If your MCP server will be accessible by browsers, then you might actually want this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mcp-Session-IdheaderProblem
Browser-based MCP clients cannot access the
Mcp-Session-Idheader from initialization responses due to CORS restrictions. Without this header, they cannot establish sessions with MCP servers.Solution
This PR adds the
corsnpm package to example servers and configures it to expose theMcp-Session-Idheader viaAccess-Control-Expose-Headers. The configuration is minimal, only exposing what's necessary for MCP protocol operation.Changes
corsimport and middleware to:sseAndStreamableHttpCompatibleServer.tssimpleStatelessStreamableHttp.tsjsonResponseStreamableHttp.tsTest plan
Mcp-Session-Idheader from responsesReported-by: Jerome