fix: Argument notation to allow parseArgs to parse leading dash-options #664
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardkmichael
changed the title
richardkmichael
force-pushed
the
fix-dashed-mcp-args
branch
from
a303533 to
b2df6f9
Compare
9 tasks
The server was invoked as: `server/build/index.js --command comm --args arg1 arg2 arg3` (`arg1 arg2 arg3` is a string in ARGV; the single value of `--args`.) `util:parseArgs()` cannot handle an argument value with a leading dash with this usage. e.g., `server/build/index.js --command npm --args --silent --prefix path/to/servers/src/everything run start` The above will throw, and indicate correct usage: ``` TypeError [ERR_PARSE_ARGS_INVALID_OPTION_VALUE]: Option '--args' argument is ambiguous. Did you forget to specify the option argument for '--args'? To specify an option argument starting with a dash use '--args=-XYZ'. ``` However, since users do not control the invocation of the server, they cannot adjust the notation for their use-case. `arguments`, and `command`, are unknown user input, so adjust the argument form to the more lenient and robust notation. Although a `command` beginning with `-` seems unlikely, consistent handling of both improves code clarity and simplicity. Running the server directly (e.g., on the command line in development) may continue to use: `--args arg1 arg2 arg3` if desired, so this is a non-breaking change.
|
@felixweinberger 👋 Any chance you could have a look? |
richardkmichael
force-pushed
the
fix-dashed-mcp-args
branch
from
305529e to
dc5fa6a
Compare
This was referenced Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke the server with an argument notation that tolerates a dash-option. Closes #649
Motivation and Context
There is an argument handling regression, and it is helpful to be able to pass a dash-option to the MCP server command.
How Has This Been Tested?
Running locally with both CLI and config file options.
Breaking Changes
No
Types of changes
Checklist
Additional context
This is not related to parsing of the initial command by
cli/build/cli.js(package entry point)., i.e., no quoting or use of--separation will address this bug. Arguments are parsed correctly, but the passing of the command and args during server invocation is the problem.