Add tooltip for URL field #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A quick way to see the full URL if it's cut off Inspired by @cliffhall's [comment](modelcontextprotocol#459 (comment))
cliffhall
requested changes
Jun 4, 2025
client/src/components/Sidebar.tsx
Outdated
Comment on lines
288
to
301
| <Tooltip> | ||
| <TooltipTrigger asChild> | ||
| <Input | ||
| id="sse-url-input" | ||
| placeholder="URL" | ||
| value={sseUrl} | ||
| onChange={(e) => setSseUrl(e.target.value)} | ||
| className="font-mono" | ||
| /> | ||
| </TooltipTrigger> | ||
| <TooltipContent> | ||
| {sseUrl || `Enter URL to MCP server`} | ||
| </TooltipContent> | ||
| </Tooltip> |
There was a problem hiding this comment.
Maybe make the tooltip only display if sseUrl is not null/undefined. It would seem odd to have this one place where a tooltip comes up over an empty field.
Suggested change
| <Tooltip> | |
| <TooltipTrigger asChild> | |
| <Input | |
| id="sse-url-input" | |
| placeholder="URL" | |
| value={sseUrl} | |
| onChange={(e) => setSseUrl(e.target.value)} | |
| className="font-mono" | |
| /> | |
| </TooltipTrigger> | |
| <TooltipContent> | |
| {sseUrl || `Enter URL to MCP server`} | |
| </TooltipContent> | |
| </Tooltip> | |
| { sseUrl && <Tooltip> | |
| <TooltipTrigger asChild> | |
| <Input | |
| id="sse-url-input" | |
| placeholder="URL" | |
| value={sseUrl} | |
| onChange={(e) => setSseUrl(e.target.value)} | |
| className="font-mono" | |
| /> | |
| </TooltipTrigger> | |
| <TooltipContent> | |
| {sseUrl} | |
| </TooltipContent> | |
| </Tooltip> } |
Done in 2ecfdb0. |
cliffhall
previously approved these changes
Jun 5, 2025
Updated. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
A quick way to see the full URL if it's cut off
Inspired by @cliffhall's comment
How Has This Been Tested?
Enter URL to MCP serverBreaking Changes
Types of changes
Checklist
Additional context