-
Notifications
You must be signed in to change notification settings - Fork 768
Feat/cli http #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/cli http #479
Conversation
I am unsure how maintainers want this tested. It seems like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry I missed your question about the test script. This test doesn't run on CI yet, so there might be something that broke the CLI test script.
I was able to run the cli\scripts\cli-tests.js if I changed this part starting on line 64:
// Create a temporary directory for test files
const TEMP_DIR = path.join(os.tmpdir(), "mcp-inspector-tests");
fs.mkdirSync(TEMP_DIR, { recursive: true });
We are also very interested in this feature internally as we only support this transport type for development tools. |
Hey Ofek, us too. I will work on this now. |
Added tests for http transport. The SSE transport on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just need to run this to fix formatting check failure in CI:
npx prettier --write cli/scripts/cli-tests.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks! When might this be released? |
@ofek I will create one today, there might be an unrelated bug fix we want to get in as well, but if not we can just release what is here now. |
Thanks! It looks like the release needs manual intervention: https://github.com/modelcontextprotocol/inspector/actions/runs/15891752275 |
Hi @ofek , yes someone from the core maintainers team needs to approve that part. Will keep you posted. |
No worries! How long does that usually take? |
@ofek usually its only around 1 working day or so, I think it flew under the radar this time. But it should be live now: https://www.npmjs.com/package/@modelcontextprotocol/inspector?activeTab=versions |
i've added a very small p/r #578 that allows other paths that do not necessarily end in |
This feature introduces streamable http support for the CLI mode. It is backward compatible; the default transport is sse. There is a new flag for --transport. Otherwise, the transport will be inferred from the suffix of the url (/mcp or /sse).
Motivation and Context
The CLI lags behind the client for Streamable HTTP support.
Closes #410
How Has This Been Tested?
Breaking Changes
No breaking changes
Types of changes
Checklist
Additional context