MQTT sample can't work properly #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 93.95% 93.95%
=======================================
Files 8 8
Lines 1141 1141
=======================================
Hits 1072 1072
Misses 69 69 Continue to review full report at Codecov.
|
|
Thank you! |
|
Good catch, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQTTのサンプルがv0.0.5のアップデート時に正しく動作しないようなコードに書き変わってしまっていたのでその修正です。
cmd_queueはasyncioのループ内で生成する必要がありました。
51行目でNoneを入れるとlintエラーが発生するので２回生成してます。
また、lintの問題がありますが、#59 の変更も取り込まないとBLEの状態変化をキャッチできません。