Ensure we have the latest pip version in build environments #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 8 8
Lines 384 384
=======================================
Hits 368 368
Misses 16 16 Continue to review full report at Codecov.
|
The `testenv:lint` environment is handled entirely by `pre-commit`, and `poetry` does not install anything directly.
|
The logs certainly show that without this PR, the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that our CI with macOS environment occasionally fails.
This PR fixes it by ensuring that we use the latest version of
pipin build envs.According to the log, it seems that
tenacitywhich is vendored inpipfails to importingtornadomodules. The issues here seems to be solved at pypa/pip#10029, and the latest release (21.1.3) contains it.