fix: config for windows machine #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puhitaku
reviewed
Sep 3, 2021
| source "https://rubygems.org" | ||
|
|
||
| gem "github-pages", group: :jekyll_plugins | ||
| gem "webrick" if Gem.win_platform? |
There was a problem hiding this comment.
webrick also needs to be added here for other OSes (confirmed on my Mac + macOS Big Sur 11.5.2)
Suggested change
| gem "webrick" if Gem.win_platform? | |
| gem "webrick" |
|
@rupeshtiwari Could you commit this change? And I mention @mmistakes since he may not be aware of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows machine we get below error therefore I added
webrickAlso first time run is getting error about repo name so I added dummy repo name and user must change the repo name as per their repo name.
I think u should merge my pull request which will make our template more ready to use. I also added steps to start jekyll site in our readme file.