Skip to content

Feature/generate completion info #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2025
Merged

Feature/generate completion info #259

merged 4 commits into from
Apr 1, 2025

Conversation

ronaldmannak
Copy link
Contributor

This PR makes the properties of GenerateCompletionInfo public

davidkoski
davidkoski requested changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it should probably also have an init like GenerateResult does -- in case somebody wants to implement their own asynchronous iterator.

@ronaldmannak
Copy link
Contributor Author

@davidkoski added!

@davidkoski
Copy link
Collaborator

It looks like CI failed on swift-format checks

@ronaldmannak
Copy link
Contributor Author

ronaldmannak commented Apr 1, 2025 •
edited
Loading

@davidkoski Both swift-format --in-place Libraries/MLXLMCommon/Evaluate.swift and swift-format format --in-place --recursive Libraries Tools Applications pass on my machine. Is there anything special I need to do?
Never mind, was on the wrong branch. It's fixed now

davidkoski
davidkoski approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@davidkoski davidkoski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for these additions!

@davidkoski davidkoski merged commit cb66b4b into ml-explore:main Apr 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkoski davidkoski davidkoski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronaldmannak @davidkoski