Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Conversation

@milk1000cc
Copy link

Mixi's new authentication method recommends to use server_state parameter.
http://developer.mixi.co.jp/connect/mixi_graph_api/api_auth/
When scope parameter includes openid, server_state is surely required.

And I wrote credentials block to return id_token because this token is needed to migrate from mixi OpenID.
http://developer.mixi.co.jp/connect/mixi_graph_api/migration_from_mixi_openid/

@ritou
Copy link

ritou commented Oct 13, 2015

👍

server_stateの使い方など、問題ないように見えます。
念のため、他の方にも見ていただきます。

.travis.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なぜバージョン指定を落としているのでしょうか?このPRの内容と関係ないように思うのですが。

@kubo39
Copy link
Contributor

kubo39 commented Oct 16, 2015

failしているテストをみると
https://travis-ci.org/mixi-inc/omniauth-mixi/jobs/84458296

Gem::InstallError: listen requires Ruby version >= 1.9.3.
Using omniauth-mixi 1.0.0 from source at .
An error occurred while installing listen (3.0.3), and Bundler cannot continue.

依存gemのサポートバージョンの問題のようです。guardで使っているんですね。

ローカルでテストを実行するためだけのライブラリなのでそちらを切ってしまってもいいかもしれません。

@milk1000cc milk1000cc force-pushed the support-server-state branch from f4d6592 to 950eb0d Compare January 16, 2017 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants