Exit with non-zero if any job failed or was skipped #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently any errors coming the underlying tarsnap commands are logged. This is not threaded back to the entrypoint of the application though, so we end up exiting with a zero code despite one or more of the jobs having failed. This makes monitoring the status of tarsnapper impossible. One would have to know to regularly check its logs to ensure it's actually backing things up. Fixes miracle2k#39
|
Ooh, I didn't even realize it always returned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any errors coming the underlying tarsnap commands are logged. This is not threaded back to the entrypoint of the application though, so we end up exiting with a zero code despite one or more of the jobs having failed. This makes monitoring the status of tarsnapper impossible. One would have to know to regularly check its logs to ensure it's actually backing things up.
Fixes #39