License Comparisson updates #3532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Valdivia <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR updates license comparison content by refining feature labels, license plan names, and UI styling. Key changes include:
- Updating feature labels and associated content in FEATURE_ITEMS.
- Renaming license plan names and adjusting button text for clarity.
- Tweaking UI styles (font sizes and margins) in LicensePlans.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| web-app/src/screens/Console/License/utils.tsx | Updated feature labels and license plan names; introduced a new "Features" block and commented out legacy sections. |
| web-app/src/screens/Console/License/LicensePlans.tsx | Adjusted button text and updated styling (font size/margins) for plan display. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the license information and UI text to improve clarity and consistency across the Console.
- Update license feature labels and details in the utils module
- Remove outdated feature groups and consolidate information
- Adjust UI styling and button text in LicensePlans for a more polished appearance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web-app/src/screens/Console/License/utils.tsx | Updated license feature labels, removed deprecated feature groups, and refined plans information |
| web-app/src/screens/Console/License/LicensePlans.tsx | Modified font sizes, margins, and updated button text for a consistent UI |
Comments suppressed due to low confidence (1)
web-app/src/screens/Console/License/utils.tsx:77
- [nitpick] Consider refactoring this long comma-separated string into a structured format (e.g., an array or a list rendered dynamically) to enhance readability and maintainability.
content: "Basic Features, S3 Express, Non-Disruptive Upgrade, QoS, Catalog, Monitoring, Audit Logs, Health-Diagnostics, RDMA, GPU Direct, AI Features",
huncrys
pushed a commit
to huncrys/minio-console
that referenced
this pull request
Jun 8, 2025
* License Comparisson updates Signed-off-by: Daniel Valdivia <[email protected]> * Prettier --------- Signed-off-by: Daniel Valdivia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.