error handling in bucket creation ui #3455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsvmx
requested review from
reivaj05,
cesnietor,
dvaldivia,
bexsoft,
bayasdev and
kannappanr
bayasdev
suggested changes
Oct 22, 2024
web-app/src/screens/Console/Buckets/ListBuckets/AddBucket/addBucketsSlice.ts
Outdated
Show resolved
Hide resolved
reivaj05
previously approved these changes
Oct 22, 2024
bayasdev
approved these changes
Oct 23, 2024
cesnietor
approved these changes
Oct 23, 2024
|
@prakashsvmx could you please take a look at the failing tests, seem unrelated but all permission ones are failing |
|
@cesnietor something broken in testcafe/chrome versions in CI. there is no release/update from testcafe. we need to wait for stable release. i tried with I will investigate when there is a new release of testcafe. |
bexsoft
approved these changes
Oct 28, 2024
reivaj05
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error handling in bucket creation ui
Fixes 2459
Test cases
e.g: Create a bucket with a pattern which does not allow the user to to create ( using iam policy)