Skip to content

Bucket encryption checkbox and endpoints for Console #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2020
Merged

Bucket encryption checkbox and endpoints for Console #343

merged 2 commits into from
Oct 25, 2020

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Oct 23, 2020 •
edited
Loading

Screen Shot 2020-10-23 at 4 46 11 PM

Screen Shot 2020-10-23 at 4 46 20 PM

Screen Shot 2020-10-23 at 4 46 02 PM

Screen Shot 2020-10-23 at 4 46 06 PM

@Alevsk Alevsk force-pushed the bucket-encryption branch from 6b25714 to 936e92d Compare October 23, 2020 05:38
@Alevsk Alevsk self-assigned this Oct 23, 2020
@Alevsk Alevsk added the WIP This PR is WIP and cannot be merged yet label Oct 23, 2020
@Alevsk Alevsk force-pushed the bucket-encryption branch 2 times, most recently from 181cba0 to f0830f2 Compare October 23, 2020 23:47
cesnietor
cesnietor reviewed Oct 24, 2020
View reviewed changes
@Alevsk Alevsk removed the WIP This PR is WIP and cannot be merged yet label Oct 24, 2020
@Alevsk Alevsk force-pushed the bucket-encryption branch from f0830f2 to 59b8fef Compare October 24, 2020 02:20
@Alevsk Alevsk requested a review from cesnietor October 24, 2020 02:20
cesnietor
cesnietor approved these changes Oct 24, 2020
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit 619ac12 into minio:master Oct 25, 2020
@Alevsk Alevsk deleted the bucket-encryption branch October 26, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesnietor cesnietor cesnietor approved these changes

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft Awaiting requested review from bexsoft

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

Assignees

@Alevsk Alevsk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alevsk @cesnietor @dvaldivia