Provide workaround for circular dependency #3361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramondeklein
force-pushed
the
circdep-workaround
branch
from
3ea4a03 to
b37c128
Compare
ramondeklein
force-pushed
the
circdep-workaround
branch
from
0a351b6 to
6b67e9c
Compare
ramondeklein
requested review from
harshavardhana,
donatello,
dvaldivia and
bexsoft
harshavardhana
approved these changes
May 29, 2024
|
this provides a proper alternative we should take this in. |
|
PTAL @donatello |
|
PTAL @dvaldivia |
donatello
approved these changes
May 29, 2024
|
@harshavardhana Can you merge? I don't am authorized to merge in console. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR If you create a PR in this repo that depends on changed code in the https://github.com/minio/minio repository, then make sure you push that code to your fork of https://github.com/minio/minio with the same branch name before pushing to the console repo.
Details
This PR only changes the build procedure to provide a workaround to the cricular dependency that may result in a failing build. Suppose that you create a PR in the console that depends on certain code in the https://github.com/minio/minio repository, then the Github actions often fail, because it tried to build against the
masterbranch of the MinIO repository in the MinIO account.This PR changes the behaviour, because it will try to build against the MinIO repository in the account where the PR is originating from. So if you create a PR in https://github.com/ramondeklein/console with branch
example, then it will try to checkout https://github.com/ramondeklein/minio (branchexample) before it falls back to https://github.com/minio/minio (branchmaster).I would have liked to avoid repeating code, but Github actions still doesn't support YAML anchors 👎🏻