Skip to content

React Router fixes for Console #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2020
Merged

React Router fixes for Console #336

merged 1 commit into from
Oct 21, 2020

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Oct 21, 2020 •
edited
Loading

  • Adding protectedRoute component
  • Removed unnecessary redirect login

Fixes - #326

@Alevsk Alevsk self-assigned this Oct 21, 2020
cesnietor
cesnietor reviewed Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not working for me, it is still redirecting to dashboard if you go to the url: http://localhost:9090/object-browser or other urls.
Run it on port 9090 cause on 5000 it does work.

@Alevsk
React Router fixes for Console
093f3e7 
- Adding protectedRoute component
- Removed unnecessary redirect login
@Alevsk Alevsk requested a review from cesnietor October 21, 2020 19:31
@Alevsk
Copy link
Contributor Author

Alevsk commented Oct 21, 2020 •
edited
Loading

It is not working for me, it is still redirecting to dashboard if you go to the url: http://localhost:9090/object-browser or other urls.
Run it on port 9090 cause on 5000 it does work.

good catch, I sent the fix for this already

@Alevsk Alevsk requested a review from harshavardhana October 21, 2020 19:32
bexsoft
bexsoft approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit 0c43e5c into minio:master Oct 21, 2020
@Alevsk Alevsk deleted the router-fixes branch October 21, 2020 20:22
@Alevsk Alevsk mentioned this pull request Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesnietor cesnietor cesnietor approved these changes

@kaankabalak kaankabalak kaankabalak approved these changes

@bexsoft bexsoft bexsoft approved these changes

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

Assignees

@Alevsk Alevsk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Alevsk @cesnietor @kaankabalak @bexsoft @dvaldivia